Skip to content

Reapply "Latest mutant" #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Reapply "Latest mutant" #1888

wants to merge 3 commits into from

Conversation

mostlyobvious
Copy link
Member

This reverts commit 75e5464.

This reverts commit 75e5464.
* mutant signalled some unhandled mutations around key.to_s

* which lead to the investigation that we should not need key.to_s at
  all

* the reason we have to do it is because of the tests,
  transformation tested on their own do not pass through
  SymbolizeMetadaKeys which is part of every mapper — when such
  transformation is not present as part of the pipeline the keys wound
  not be symbols: thus the key.to_s fallback
* we actually should check both variants, with SymbolizeMetadataKeys as
  in the mappers we provide and when transformation is used standalone
  — in case someone composes mappers as they wish

At this point I don't understand why ostruct would always have symbols,
while active_support_time_with_zone would differentiate.

WELP.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant